Deprecate ntuple(::Integer, ::Function) #11486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some day we will want to duck-type the Function argument to ntuple, but we need one release cycle with a deprecation warning before we can do that. So let's do the deprecation now.
It's inferrable with Functors and FastAnonymous, but not (currently) generic functions.
|
Since little controversy seems to have been stirred up, and approval for the general idea was given in #9961, merging. |
timholy
added a commit
that referenced
this pull request
May 31, 2015
Deprecate ntuple(::Integer, ::Function)
|
Since ntuple got deprecated, I think someone should modify the ndgrid.jl file in the examples directory. |
|
Fixed in 85e3fe0. If you noticed this because you use |
|
Hm. Why didn't Line 23 in 85e3fe0 |
|
@tkelman In the examples.jl, the call to ndgrid was 2 AbstractVectors. The warning would only appear if the call has 3 or more of them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should do this now, because someday we may want to duck-type the function argument (FastAnonymous or otherwise). But we need one release cycle of deprecation first.
More controversially, I also added an inferrable variant of
ntuple. It's based onValand@generatedfunctions, the latter of which is the likely source of controversy. I separated this into a separate commit so that it can be easily dropped, if necessary.